Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-5836 - Add news to KNLDeletion Module #4654

Merged
merged 62 commits into from
Feb 6, 2024
Merged

BC-5836 - Add news to KNLDeletion Module #4654

merged 62 commits into from
Feb 6, 2024

Conversation

WojciechGrancow
Copy link
Contributor

@WojciechGrancow WojciechGrancow commented Dec 19, 2023 •
edited by KacperPassCon
Loading

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-5836

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@WojciechGrancow WojciechGrancow added the WIP This feature branch is in progress, do not merge into master. label Dec 19, 2023
@WojciechGrancow WojciechGrancow self-assigned this Dec 19, 2023
WojciechGrancow and others added 19 commits December 29, 2023 09:34
@WojciechGrancow
add logger to registrationPin deleteService
64830b3
@WojciechGrancow
add logger to dashboardModule deleteService
a5bae20
@WojciechGrancow
add logger to classModule deleteService
8a9247a
@WojciechGrancow
add logger to courseGroupService for delete method
b8df859
@WojciechGrancow
add logger to courseService for delete method
72627f8
@WojciechGrancow
add logger to FilesModule for removePermision and markFordeletion
59740db
@WojciechGrancow
add logger to LessonModule for removeUserData from lessons
e596193
@WojciechGrancow
add logger to pseudonymService and add logger import in course test
1d888f9
@WojciechGrancow
add logger to teamService in team module
45f886b
@WojciechGrancow
add logger to userService for deleteUsermethod in user module
37e31c7
@WojciechGrancow
add logger to RocketChatUser and to RocketChat Services for delete me…
6f4f906 
…thods
@WojciechGrancow @bn-pass
Update apps/server/src/modules/learnroom/service/course.service.spec.ts
ca57167 
Co-authored-by: Bartosz Nowicki <[email protected]>
@WojciechGrancow
add additional metadata to logs during deletion user data for services
9b74b29
@WojciechGrancow
fix test
1dbfedc
@WojciechGrancow
Merge branch 'main' into BC-6082-add-logger-to-KNL-module
289175d
@WojciechGrancow
some fixes
dce0c7b
@WojciechGrancow
Merge branch 'main' into BC-6082-add-logger-to-KNL-module
ba666be
@WojciechGrancow
fix after review
93393b9
@WojciechGrancow
Merge branch 'main' into BC-6082-add-logger-to-KNL-module
5caf15d
@WojciechGrancow WojciechGrancow removed their assignment Jan 10, 2024
bn-pass
bn-pass previously approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@bn-pass bn-pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just some small adjustments.

apps/server/src/modules/news/mapper/news.mapper.ts Outdated Show resolved Hide resolved
apps/server/src/modules/news/uc/news.uc.spec.ts Outdated Show resolved Hide resolved
@bn-pass bn-pass dismissed their stale review January 26, 2024 20:43

didn't spot one important thing before

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@WojciechGrancow WojciechGrancow merged commit e2f3388 into main Feb 6, 2024
47 of 48 checks passed
@WojciechGrancow WojciechGrancow deleted the BC-5836-Add-News-to-KNLDeletion branch February 7, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sszafGCA sszafGCA sszafGCA left review comments

@Loki-Afro Loki-Afro Loki-Afro left review comments

@blazejpass blazejpass blazejpass approved these changes

@bn-pass bn-pass bn-pass approved these changes

@virgilchiriac virgilchiriac virgilchiriac approved these changes

Assignees

@sszafGCA sszafGCA

@WojciechGrancow WojciechGrancow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@WojciechGrancow @Loki-Afro @virgilchiriac @sszafGCA @bn-pass @blazejpass